[Documentation:Developer] Improve php unit test instructions#686
Merged
[Documentation:Developer] Improve php unit test instructions#686
Conversation
lavalleeale
requested changes
Jul 16, 2025
Contributor
lavalleeale
left a comment
lavalleeale
left a comment
There was a problem hiding this comment.
I made one specific suggestion, but I think we should discuss as a team before this gets merged since a lot of the install_php.md file seems outdated around what you added.
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Co-authored-by: Alex Lavallee <alex@lavallee.one>
lavalleeale
approved these changes
Jul 17, 2025
Contributor
lavalleeale
left a comment
lavalleeale
left a comment
There was a problem hiding this comment.
Docs now match correct commands, lgtm
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that no one knows how to run the full php unit test suite and have it pass, so I investigated the php unit test instructions and Improved them. @lavalleeale has some changes at https://github.com/Submitty/Submitty/pull/11802 to allow for the full suite to pass so these docs should match that.